Skip to content

Set authSetting when creating users via the Tableau REST API #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aberoham wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set authSetting when creating users via the Tableau REST API #28

aberoham wants to merge 1 commit into from

Conversation

@aberoham
Copy link

@aberoham aberoham commented Feb 3, 2026 •
edited by coderabbitai bot
Loading

Fixes #27.

AddUserToSite sets idpConfigurationId but never includes authSetting in the API payload. The Tableau REST API requires authSetting to be explicitly set — without it, every user defaults to "Tableau with MFA" regardless of the IdP configuration provided.

  • CreateAccount now sets AuthSetting to "SAML" when an IdP is selected, "TableauIDWithMFA" otherwise.
  • AddUserToSite now passes AuthSetting through to the API payload when set, rather than silently dropping it.

Tested against the Tableau Cloud REST API (3.17); both SAML and TableauIDWithMFA are correctly reflected on the created user.

Summary by CodeRabbit

  • New Features
    • Explicit authentication method selection during account provisioning. Accounts using IDP configuration are now automatically set to SAML authentication; others default to Tableau ID with MFA.

@aberoham @claude
Set authSetting when creating users via the Tableau REST API
fd084ac 
AddUserToSite sets idpConfigurationId but never includes authSetting in
the payload. The Tableau REST API requires authSetting to be explicit —
without it, users default to "Tableau with MFA" regardless of IdP config.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@aberoham aberoham requested a review from a team February 3, 2026 12:19
@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026 •
edited
Loading

Walkthrough

The changes add explicit authentication setting configuration for user provisioning. When creating users, the code now populates the authentication method field based on IDP configuration presence—"SAML" when an IDP is provided, "TableauIDWithMFA" otherwise.

Changes

Cohort / File(s) Summary
Authentication Setting Configuration
pkg/connector/user.go, pkg/tableau/client.go		 Added logic to set AuthSetting field conditionally: "SAML" for IDP-configured users, "TableauIDWithMFA" for standard authentication. Ensures authentication method is explicitly included in user creation payloads.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A user springs forth with SAML's grace,
Or MFA arms for the standard case,
No more silent settings, now explicit and clear,
Authentication paths that the API can hear!
🔐✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: setting the authSetting field when creating users via the Tableau REST API.
Linked Issues check ✅ Passed The PR fully addresses the requirements from issue #27: CreateAccount now sets AuthSetting based on IdP presence, and AddUserToSite now includes AuthSetting in the API payload.
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing issue #27; modifications to CreateAccount and AddUserToSite align with the linked issue objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • ✨ 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JavierCarnelli-ConductorOne JavierCarnelli-ConductorOne Awaiting requested review from JavierCarnelli-ConductorOne

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AddUserToSite omits authSetting when idpConfigurationId is set

1 participant

@aberoham